feat(pv-stylemark): add theme classes from the old stylemark to the new one #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew one this allows any existing theming to mostly also work in the new one
|
adding this classes would just move the upgrading effort to the future and add complexity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
== Description ==
this allows any existing customization css / theming to mostly also work in the new one
classes not supported from old stylemark are:
theme-mobile-navtheme-mobile-nav-selecttheme-sidebar-footertheme-sidebar-search-no-resultstheme-sidebar-header-title(might have been handy to show a title in addition to the logo, in case same brand has more than one styleguide)== Closes issue(s) ==
== Changes ==
== Affected Packages ==
pv-styleamrk